Token support

2 replies [Last post]
aidan
Offline
Joined: 10/28/2009
Status: 
Answered

Looks great!

A few suggestions:

1. where you've put the "Replacement patterns", you've listed it twice for three emails. Either list it three times or just once at the bottom (just once being preferred, faster and better UX).

2. you still include the old tokens in the input description, which is confusing if the token module is installed.

3. some of your token names overwrite tokens provided by other modules! The convention is to prefix the token with the type, so all of the "site" types are "site-date", "site-name", etc ... the affiliate tokens should be "affiliate-balance", etc. Also they should be lowercase. Unfortunately the token values array is flat, which is why it's confusing.

 

Thanks for the new release!

aidan
Offline
Joined: 10/28/2009
4. you've created your own

4. you've created your own token type, but that means none of the user tokens are loaded! We want the user tokens loaded, not the global / affiliate tokens.

aidan
Offline
Joined: 10/28/2009
When you get a chance it

When you get a chance it would be great to have some feedback on this.

Twitter Feed